add object diff to log with duplicate entity report #1140
Merged
+247
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonaldEAM
force-pushed
the
add-diff-duplicate-entity-report
branch
from
1be6069 to
d0d01f4
Compare
RonaldEAM
force-pushed
the
add-diff-duplicate-entity-report
branch
from
d0d01f4 to
e7240a0
Compare
VDubber
reviewed
Dec 5, 2024
packages/integration-sdk-runtime/src/execution/duplicateKeyTracker.ts
Outdated
Show resolved
Hide resolved
VDubber
reviewed
Dec 5, 2024
packages/integration-sdk-runtime/src/execution/duplicateKeyTracker.ts
Outdated
Show resolved
Hide resolved
VDubber
reviewed
Dec 5, 2024
| try { | ||
| propertiesDiff = diffObjects(aClone, bClone); | ||
| } catch (e) { | ||
| // ignore |
There was a problem hiding this comment.
It'd be nice to get a log that the diffObject operation failed. same on line 251
There was a problem hiding this comment.
This is hard to do, as we don't pass a logger to the job state code, I could add a property for the error message to the return object of this function, this ends up in a log so it could work, but it's weird. Let me know what you think!
VDubber
reviewed
Dec 5, 2024
packages/integration-sdk-runtime/src/execution/duplicateKeyTracker.ts
Outdated
Show resolved
Hide resolved
VDubber
reviewed
Dec 5, 2024
packages/integration-sdk-runtime/src/execution/duplicateKeyTracker.ts
Outdated
Show resolved
Hide resolved
VDubber
reviewed
Dec 5, 2024
VDubber
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.